From: Dan Carpenter Date: Wed, 26 May 2010 10:46:39 +0000 (+0200) Subject: PCI: hotplug/shpchp_hpc: add parenthesis in SLOT_REG_RSVDZ_MASK X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3b8fdb759e6ed446433c6dfd5a226d9007925596;p=linux-beck.git PCI: hotplug/shpchp_hpc: add parenthesis in SLOT_REG_RSVDZ_MASK The SLOT_REG_RSVDZ_MASK macro is normally used like this: slot_reg &= ~SLOT_REG_RSVDZ_MASK; The ~ operator has higher precedence than the | operator from inside the macro, so it needs parenthesis. Reviewed-by: Kenji Kaneshige Signed-off-by: Dan Carpenter Signed-off-by: Jesse Barnes --- diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index 5f5e8d2e3552..d3985e7deab7 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c @@ -113,7 +113,7 @@ #define CON_PFAULT_INTR_MASK (1 << 28) #define MRL_CHANGE_SERR_MASK (1 << 29) #define CON_PFAULT_SERR_MASK (1 << 30) -#define SLOT_REG_RSVDZ_MASK (1 << 15) | (7 << 21) +#define SLOT_REG_RSVDZ_MASK ((1 << 15) | (7 << 21)) /* * SHPC Command Code definitnions