From: Hao Wei Tee Date: Mon, 22 May 2017 10:38:55 +0000 (+0800) Subject: platform/x86: ideapad-laptop: Squelch ACPI event 1 X-Git-Tag: v4.13-rc1~135^2~57 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3cfd956b02ac7a9fb5f2414171f834871931fbd0;p=karo-tx-linux.git platform/x86: ideapad-laptop: Squelch ACPI event 1 Don't simply throw this to userspace via the sparse_keymap (which does not have a mapping for scancode 1), as this causes KEY_UNKNOWN to be emitted, which is a nuisance and of no use at all (it is not the right way to expose this ACPI event to userspace, anyway, and the original intention of the commit which added this (cfee5d63767b2e7997c1f36420d008abbe61565c) was only to suppress an unhandled event log message). Signed-off-by: Hao Wei Tee Signed-off-by: Andy Shevchenko --- diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index e4c83c15587d..d48962569364 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -844,7 +844,6 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data) case 8: case 7: case 6: - case 1: ideapad_input_report(priv, vpc_bit); break; case 5: @@ -862,6 +861,13 @@ static void ideapad_acpi_notify(acpi_handle handle, u32 event, void *data) case 0: ideapad_check_special_buttons(priv); break; + case 1: + /* Some IdeaPads report event 1 every ~20 + * seconds while on battery power; some + * report this when changing to/from tablet + * mode. Squelch this event. + */ + break; default: pr_info("Unknown event: %lu\n", vpc_bit); }