From: Daniel Vetter <daniel.vetter@ffwll.ch>
Date: Sat, 5 Apr 2014 08:10:08 +0000 (+0200)
Subject: drm/cirrus: Remove unecessary NULL check in gem_free
X-Git-Tag: next-20140502~52^2~1^2~8
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3d535eddf2b7fc93126aaf4e36c05fe751fb8c4b;p=karo-tx-linux.git

drm/cirrus: Remove unecessary NULL check in gem_free

The ->gem_free_object never gets called with a NULL pointer, the check
is redundant. Also checking after the upcast allows compilers to elide
it anyway.

Spotted by coverity.

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---

diff --git a/drivers/gpu/drm/cirrus/cirrus_main.c b/drivers/gpu/drm/cirrus/cirrus_main.c
index b119f66fed92..99c1983f99d2 100644
--- a/drivers/gpu/drm/cirrus/cirrus_main.c
+++ b/drivers/gpu/drm/cirrus/cirrus_main.c
@@ -271,8 +271,6 @@ void cirrus_gem_free_object(struct drm_gem_object *obj)
 {
 	struct cirrus_bo *cirrus_bo = gem_to_cirrus_bo(obj);
 
-	if (!cirrus_bo)
-		return;
 	cirrus_bo_unref(&cirrus_bo);
 }