From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 19 May 2007 04:57:38 +0000 (+1000)
Subject: [PATCH] CRYPTO: api: Read module pointer before freeing algorithm
X-Git-Tag: v2.6.21.2~1
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3dc006dd27bdbe69ee0069cfd037c9e7ca2dc86f;p=karo-tx-linux.git

[PATCH] CRYPTO: api: Read module pointer before freeing algorithm

The function crypto_mod_put first frees the algorithm and then drops
the reference to its module.  Unfortunately we read the module pointer
which after freeing the algorithm and that pointer sits inside the
object that we just freed.

So this patch reads the module pointer out before we free the object.

Thanks to Luca Tettamanti for reporting this.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
---

diff --git a/crypto/api.c b/crypto/api.c
index 55af8bb0f050..33734fd9198f 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -48,8 +48,10 @@ EXPORT_SYMBOL_GPL(crypto_mod_get);
 
 void crypto_mod_put(struct crypto_alg *alg)
 {
+	struct module *module = alg->cra_module;
+
 	crypto_alg_put(alg);
-	module_put(alg->cra_module);
+	module_put(module);
 }
 EXPORT_SYMBOL_GPL(crypto_mod_put);