From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Date: Thu, 30 Apr 2015 12:15:08 +0000 (-0300)
Subject: [media] saa7134-i2c: simplify debug dump and use pr_info()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3e0051c5a40a5a29e1919361f45cd1e103d0b1fa;p=linux-beck.git

[media] saa7134-i2c: simplify debug dump and use pr_info()

Instead of implement its own hexdump logic, use the printk
format, and convert to use pr_info().

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---

diff --git a/drivers/media/pci/saa7134/saa7134-i2c.c b/drivers/media/pci/saa7134/saa7134-i2c.c
index b140143dba7d..ef3c33e3757d 100644
--- a/drivers/media/pci/saa7134/saa7134-i2c.c
+++ b/drivers/media/pci/saa7134/saa7134-i2c.c
@@ -369,13 +369,12 @@ saa7134_i2c_eeprom(struct saa7134_dev *dev, unsigned char *eedata, int len)
 		       dev->name,err);
 		return -1;
 	}
-	for (i = 0; i < len; i++) {
-		if (0 == (i % 16))
-			pr_info("%s: i2c eeprom %02x:",dev->name,i);
-		printk(" %02x",eedata[i]);
-		if (15 == (i % 16))
-			printk("\n");
+
+	for (i = 0; i < len; i+= 16) {
+		int size = (len - i) > 16 ? 16 : len - i;
+		pr_info("i2c eeprom %02x: %*ph\n", i, size, &eedata[i]);
 	}
+
 	return 0;
 }