From: J. Bruce Fields <bfields@citi.umich.edu>
Date: Sat, 21 Feb 2009 21:17:19 +0000 (-0800)
Subject: nfsd4: add a helper function to decide if stateid is delegation
X-Git-Tag: v2.6.30-rc1~183^2~62
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3e633079e377d2b527a8390f63ceb887b5cabfbf;p=karo-tx-linux.git

nfsd4: add a helper function to decide if stateid is delegation

Make this check self-documenting.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
---

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 909a7a493688..d5555850cb64 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2048,6 +2048,11 @@ static int check_stateid_generation(stateid_t *in, stateid_t *ref)
 	return nfs_ok;
 }
 
+static int is_delegation_stateid(stateid_t *stateid)
+{
+	return stateid->si_fileid == 0;
+}
+
 /*
 * Checks for stateid operations
 */
@@ -2073,7 +2078,7 @@ nfs4_preprocess_stateid_op(struct svc_fh *current_fh, stateid_t *stateid, int fl
 		goto out;
 
 	status = nfserr_bad_stateid;
-	if (!stateid->si_fileid) { /* delegation stateid */
+	if (is_delegation_stateid(stateid)) {
 		dp = find_delegation_stateid(ino, stateid);
 		if (!dp)
 			goto out;