From: Li Zefan <lizf@cn.fujitsu.com>
Date: Sun, 16 Nov 2008 16:05:24 +0000 (-0500)
Subject: ext4: add missing unlock in ext4_check_descriptors() on error path
X-Git-Tag: v2.6.27.8~22
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=3f007078d237e1a09db76c18519469b894dccebf;p=karo-tx-linux.git

ext4: add missing unlock in ext4_check_descriptors() on error path

(cherry picked from commit 7ee1ec4ca30c6df8e989615cdaacb75f2af4fa6b)

If there group descriptors are corrupted we need unlock the block
group lock before returning from the function; else we will oops when
freeing a spinlock which is still being held.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 062b7c5dc68f..f98f9bbf98c1 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1626,8 +1626,10 @@ static int ext4_check_descriptors(struct super_block *sb)
 			       "Checksum for group %lu failed (%u!=%u)\n",
 			       i, le16_to_cpu(ext4_group_desc_csum(sbi, i,
 			       gdp)), le16_to_cpu(gdp->bg_checksum));
-			if (!(sb->s_flags & MS_RDONLY))
+			if (!(sb->s_flags & MS_RDONLY)) {
+				spin_unlock(sb_bgl_lock(sbi, i));
 				return 0;
+			}
 		}
 		spin_unlock(sb_bgl_lock(sbi, i));
 		if (!flexbg_flag)