From: Takashi Iwai <tiwai@suse.de>
Date: Thu, 11 Dec 2008 11:12:06 +0000 (+0100)
Subject: ALSA: sb8 - Fix a return code in the error path
X-Git-Tag: v2.6.29-rc1~590^2~9^2~6
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=42a73df435a23e60d97d9d860f4e55dc9833e950;p=karo-tx-linux.git

ALSA: sb8 - Fix a return code in the error path

Fixed a compile warning below:
  sound/isa/sb/sb8.c: In function ‘snd_sb8_probe’:
  sound/isa/sb/sb8.c:104: warning: ‘err’ may be used uninitialized in this function
by setting the return value correctly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c
index 667eccc676a4..ea06877be4b1 100644
--- a/sound/isa/sb/sb8.c
+++ b/sound/isa/sb/sb8.c
@@ -140,8 +140,10 @@ static int __devinit snd_sb8_probe(struct device *pdev, unsigned int dev)
 				break;
 			}
 		}
-		if (i >= ARRAY_SIZE(possible_ports))
+		if (i >= ARRAY_SIZE(possible_ports)) {
+			err = -EINVAL;
 			goto _err;
+		}
 	}
 	acard->chip = chip;