From: Asaf Vertz <asaf.vertz@tandemg.com>
Date: Mon, 5 Jan 2015 08:23:10 +0000 (+0200)
Subject: crypto: omap-des - fix BUG_ON condition
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=42d2e780c6239040ec29d404f87e752de3627e08;p=linux-beck.git

crypto: omap-des - fix BUG_ON condition

dd->total is unsigned so it won't do any good to check for negative
value after subtracting instead of that we should check if the
subtracted value is bigger than him

This was partially found by using a static code analysis program
called cppcheck.

Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index e350f5be4d2e..0b8dcf5eb74e 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -965,9 +965,9 @@ static irqreturn_t omap_des_irq(int irq, void *dev_id)
 			}
 		}
 
-		dd->total -= DES_BLOCK_SIZE;
+		BUG_ON(dd->total < DES_BLOCK_SIZE);
 
-		BUG_ON(dd->total < 0);
+		dd->total -= DES_BLOCK_SIZE;
 
 		/* Clear IRQ status */
 		status &= ~DES_REG_IRQ_DATA_OUT;