From: Al Viro <viro@zeniv.linux.org.uk>
Date: Sat, 13 May 2017 22:22:53 +0000 (-0400)
Subject: do_ipv6_setsockopt(): don't open-code memdup_user()
X-Git-Tag: v4.13-rc1~151^2~4
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=43727da90ec8955f1351ad582c6bc8f1c1ab8ab8;p=karo-tx-linux.git

do_ipv6_setsockopt(): don't open-code memdup_user()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
index a531ba032b85..f8298c9a3160 100644
--- a/net/ipv6/ipv6_sockglue.c
+++ b/net/ipv6/ipv6_sockglue.c
@@ -735,14 +735,9 @@ done:
 			retv = -ENOBUFS;
 			break;
 		}
-		gsf = kmalloc(optlen, GFP_KERNEL);
-		if (!gsf) {
-			retv = -ENOBUFS;
-			break;
-		}
-		retv = -EFAULT;
-		if (copy_from_user(gsf, optval, optlen)) {
-			kfree(gsf);
+		gsf = memdup_user(optval, optlen);
+		if (IS_ERR(gsf)) {
+			retv = PTR_ERR(gsf);
 			break;
 		}
 		/* numsrc >= (4G-140)/128 overflow in 32 bits */