From: Jan Kara Date: Fri, 23 Dec 2011 10:53:07 +0000 (+0100) Subject: udf: Mark LVID buffer as uptodate before marking it dirty X-Git-Tag: v3.2.6~48 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=43f4a516b2f5492bc597f3753b693ad8adc62748;p=karo-tx-linux.git udf: Mark LVID buffer as uptodate before marking it dirty commit 853a0c25baf96b028de1654bea1e0c8857eadf3d upstream. When we hit EIO while writing LVID, the buffer uptodate bit is cleared. This then results in an anoying warning from mark_buffer_dirty() when we write the buffer again. So just set uptodate flag unconditionally. Reviewed-by: Namjae Jeon Signed-off-by: Jan Kara Cc: Dave Jones Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/udf/super.c b/fs/udf/super.c index e185253470df..87cb24a0ee7b 100644 --- a/fs/udf/super.c +++ b/fs/udf/super.c @@ -1799,6 +1799,12 @@ static void udf_close_lvid(struct super_block *sb) le16_to_cpu(lvid->descTag.descCRCLength))); lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag); + /* + * We set buffer uptodate unconditionally here to avoid spurious + * warnings from mark_buffer_dirty() when previous EIO has marked + * the buffer as !uptodate + */ + set_buffer_uptodate(bh); mark_buffer_dirty(bh); sbi->s_lvid_dirty = 0; mutex_unlock(&sbi->s_alloc_mutex);