From: Sachin Kamat Date: Tue, 20 Nov 2012 09:59:02 +0000 (-0800) Subject: leds: lp3944: Fix return value X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4401e48737c4068604144a5c0ba23a9c82ea3a37;p=linux-beck.git leds: lp3944: Fix return value Return the value obtained from i2c_smbus_read_byte_data() instead of -EINVAL. Silences the following smatch warning: drivers/leds/leds-lp3944.c:89 lp3944_reg_read() info: why not propagate 'tmp' from i2c_smbus_read_byte_data() instead of -22? Signed-off-by: Sachin Kamat Signed-off-by: Bryan Wu --- diff --git a/drivers/leds/leds-lp3944.c b/drivers/leds/leds-lp3944.c index c298f7d9f535..b2d82e2d2e9d 100644 --- a/drivers/leds/leds-lp3944.c +++ b/drivers/leds/leds-lp3944.c @@ -86,7 +86,7 @@ static int lp3944_reg_read(struct i2c_client *client, u8 reg, u8 *value) tmp = i2c_smbus_read_byte_data(client, reg); if (tmp < 0) - return -EINVAL; + return tmp; *value = tmp;