From: Albert Lee <albertcc@tw.ibm.com>
Date: Tue, 1 Nov 2005 11:19:01 +0000 (+0800)
Subject: [PATCH] libata irq-pio: misc fixes
X-Git-Tag: v2.6.18-rc1~1079^2~98^2~13^2~83
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=467b16d4bebe8d251ca974eaa5da50b315206e9d;p=karo-tx-linux.git

[PATCH] libata irq-pio: misc fixes

   - ata_pio_block(): add ata_altstatus(ap) to prevent reading device status before it is valid
   - remove the unnecessary HSM_ST_IDLE state from ata_pio_task()
   - raise BUG() when unknown state is found in ata_pio_task()

Signed-off-by: Albert Lee <albertcc@tw.ibm.com>

============
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
---

diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index ce18de9705c4..15736e3313f0 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -3317,6 +3317,8 @@ static void ata_pio_block(struct ata_port *ap)
 
 		ata_pio_sector(qc);
 	}
+
+	ata_altstatus(ap); /* flush */
 }
 
 static void ata_pio_error(struct ata_port *ap)
@@ -3344,9 +3346,6 @@ fsm_start:
 	qc_completed = 0;
 
 	switch (ap->hsm_task_state) {
-	case HSM_ST_IDLE:
-		return;
-
 	case HSM_ST:
 		ata_pio_block(ap);
 		break;
@@ -3364,6 +3363,10 @@ fsm_start:
 	case HSM_ST_ERR:
 		ata_pio_error(ap);
 		return;
+
+	default:
+		BUG();
+		return;
 	}
 
 	if (timeout)