From: Arnd Bergmann Date: Mon, 22 May 2017 13:07:03 +0000 (+0200) Subject: platform/x86: ideapad-laptop: hide unused 'touchpad_store' X-Git-Tag: v4.13-rc1~135^2~58 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=46936fd65c107ed935e21bfa6fc00b4f510b1714;p=karo-tx-linux.git platform/x86: ideapad-laptop: hide unused 'touchpad_store' A readonly sysfs property must not have a 'store' function: drivers/platform/x86/ideapad-laptop.c:438:16: error: 'touchpad_store' defined but not used [-Werror=unused-function] We can either comment it out or remove the function entirely, without a good reason one or or another I picked the second option. Fixes: 7f363145992c ("platform/x86: ideapad-laptop: Switch touchpad attribute to be RO") Signed-off-by: Arnd Bergmann Signed-off-by: Andy Shevchenko --- diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index f7a4608cc60b..e4c83c15587d 100644 --- a/drivers/platform/x86/ideapad-laptop.c +++ b/drivers/platform/x86/ideapad-laptop.c @@ -435,9 +435,10 @@ static ssize_t touchpad_show(struct device *dev, return sprintf(buf, "%lu\n", result); } -static ssize_t touchpad_store(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t count) +/* Switch to RO for now: It might be revisited in the future */ +static ssize_t __maybe_unused touchpad_store(struct device *dev, + struct device_attribute *attr, + const char *buf, size_t count) { struct ideapad_private *priv = dev_get_drvdata(dev); bool state; @@ -453,7 +454,6 @@ static ssize_t touchpad_store(struct device *dev, return count; } -/* Switch to RO for now: It might be revisited in the future */ static DEVICE_ATTR_RO(touchpad); static struct attribute *ideapad_attributes[] = {