From: Thomas Hellstrom <thomas-at-tungstengraphics-dot-com>
Date: Thu, 21 Sep 2006 18:04:18 +0000 (+1000)
Subject: drm: Fix hashtab implementation leaking illegal error codes to user space.
X-Git-Tag: v2.6.19-rc1~641^2~5
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=47cc140931cc03076014fdbfdd512d6dd9d74d34;p=karo-tx-linux.git

drm: Fix hashtab implementation leaking illegal error codes to user space.

reported by Dave Airlie

Signed-off-by: Dave Airlie <airlied@linux.ie>
---

diff --git a/drivers/char/drm/drm_hashtab.c b/drivers/char/drm/drm_hashtab.c
index 480611395481..a0b2d6802ae4 100644
--- a/drivers/char/drm/drm_hashtab.c
+++ b/drivers/char/drm/drm_hashtab.c
@@ -106,7 +106,7 @@ int drm_ht_insert_item(drm_open_hash_t *ht, drm_hash_item_t *item)
 	hlist_for_each(list, h_list) {
 		entry = hlist_entry(list, drm_hash_item_t, head);
 		if (entry->key == key)
-			return -1;
+			return -EINVAL;
 		if (entry->key > key)
 			break;
 		parent = list;
@@ -154,7 +154,7 @@ int drm_ht_find_item(drm_open_hash_t *ht, unsigned long key,
 
 	list = drm_ht_find_key(ht, key);
 	if (!list)
-		return -1;
+		return -EINVAL;
 
 	*item = hlist_entry(list, drm_hash_item_t, head);
 	return 0;
@@ -170,7 +170,7 @@ int drm_ht_remove_key(drm_open_hash_t *ht, unsigned long key)
 		ht->fill--;
 		return 0;
 	}
-	return -1;
+	return -EINVAL;
 }
 
 int drm_ht_remove_item(drm_open_hash_t *ht, drm_hash_item_t *item)