From: Ricardo Neri Date: Tue, 6 Nov 2012 06:19:12 +0000 (-0600) Subject: OMAPDSS: HDMI: Convert to devm_request_and_ioremap X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=47e443bce78472ecee8d4246ac726f0a9c19cbd1;p=linux-beck.git OMAPDSS: HDMI: Convert to devm_request_and_ioremap Using devm_request_and_ioremap provides better memory handling and improves readability. Signed-off-by: Ricardo Neri Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index 72ab260cfb27..1d04bc0479e7 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c @@ -1064,7 +1064,7 @@ static int __init omapdss_hdmihw_probe(struct platform_device *pdev) } /* Base address taken from platform */ - hdmi.ip_data.base_wp = ioremap(res->start, resource_size(res)); + hdmi.ip_data.base_wp = devm_request_and_ioremap(&pdev->dev, res); if (!hdmi.ip_data.base_wp) { DSSERR("can't ioremap WP\n"); return -ENOMEM; @@ -1072,7 +1072,7 @@ static int __init omapdss_hdmihw_probe(struct platform_device *pdev) r = hdmi_get_clocks(pdev); if (r) { - iounmap(hdmi.ip_data.base_wp); + DSSERR("can't get clocks\n"); return r; } @@ -1117,8 +1117,6 @@ static int __exit omapdss_hdmihw_remove(struct platform_device *pdev) hdmi_put_clocks(); - iounmap(hdmi.ip_data.base_wp); - return 0; }