From: Cindy H Kao Date: Wed, 31 Mar 2010 02:19:37 +0000 (-0700) Subject: wimax/i2400m: correct the error path handlers in dev_start() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=49d72df3f6cd63b49528306a2577ae7a6a0e9d6b;p=linux-beck.git wimax/i2400m: correct the error path handlers in dev_start() This fix is to correct order of the handlers in the error path of dev_start(). When i2400m_firmware_check fails, all the works done before it should be released or cleared. Signed-off-by: Cindy H Kao --- diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c index 94dc83c3969d..3a6c8ddb5353 100644 --- a/drivers/net/wimax/i2400m/driver.c +++ b/drivers/net/wimax/i2400m/driver.c @@ -403,10 +403,10 @@ retry: error_dev_initialize: error_check_mac_addr: +error_fw_check: i2400m->ready = 0; wmb(); /* see i2400m->ready's documentation */ flush_workqueue(i2400m->work_queue); -error_fw_check: if (i2400m->bus_dev_stop) i2400m->bus_dev_stop(i2400m); error_bus_dev_start: