From: Nicholas Bellinger Date: Tue, 17 Jan 2012 01:11:54 +0000 (-0800) Subject: iscsi-target: Fix double list_add with iscsit_alloc_buffs reject X-Git-Tag: v3.2.6~33 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=49f4afd3b15866b16b72691a6060fad041e8f2dc;p=karo-tx-linux.git iscsi-target: Fix double list_add with iscsit_alloc_buffs reject commit cd931ee62fd0258fc85c76a7c5499fe85e0f3436 upstream. This patch fixes a bug where the iscsit_add_reject_from_cmd() call from a failure to iscsit_alloc_buffs() was incorrectly passing add_to_conn=1 and causing a double list_add after iscsi_cmd->i_list had already been added in iscsit_handle_scsi_cmd(). Signed-off-by: Nicholas Bellinger Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 8599545cdf9e..3b46e3a692c0 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c @@ -1062,7 +1062,7 @@ attach_cmd: if (ret < 0) return iscsit_add_reject_from_cmd( ISCSI_REASON_BOOKMARK_NO_RESOURCES, - 1, 1, buf, cmd); + 1, 0, buf, cmd); /* * Check the CmdSN against ExpCmdSN/MaxCmdSN here if * the Immediate Bit is not set, and no Immediate