From: Bert Vermeulen Date: Mon, 20 Apr 2015 13:53:25 +0000 (+0200) Subject: spi: rb4xx: Fix set_cs logic. X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4a1ae8be4563d29ddd36f46759191f4e867ed954;p=linux-beck.git spi: rb4xx: Fix set_cs logic. As it turns out, the set_cs() enable parameter refers to the logic level on the CS pin, not the state of chip selection. This broke functionality of the LEDs behind the CPLD, or at least delayed the commands until another one came in to toggle CS. Signed-off-by: Bert Vermeulen Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-rb4xx.c b/drivers/spi/spi-rb4xx.c index 9b449d4f9871..50f49f38e73c 100644 --- a/drivers/spi/spi-rb4xx.c +++ b/drivers/spi/spi-rb4xx.c @@ -90,7 +90,7 @@ static void rb4xx_set_cs(struct spi_device *spi, bool enable) * since it's all on the same hardware register. However the * CPLD needs CS deselected after every command. */ - if (!enable) + if (enable) rb4xx_write(rbspi, AR71XX_SPI_REG_IOC, AR71XX_SPI_IOC_CS0 | AR71XX_SPI_IOC_CS1); }