From: Dan Carpenter Date: Thu, 14 Nov 2013 08:19:18 +0000 (+0300) Subject: video: mmp: delete a stray mutex_unlock() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4ac8bd618b6c70fbc043c82f95d2d9b529c57109;p=linux-beck.git video: mmp: delete a stray mutex_unlock() We aren't holding the disp_lock so we shouldn't release it. Signed-off-by: Dan Carpenter Acked-by: Haojian Zhuang Signed-off-by: Tomi Valkeinen --- diff --git a/drivers/video/mmp/core.c b/drivers/video/mmp/core.c index 84de2632857a..c8d426541612 100644 --- a/drivers/video/mmp/core.c +++ b/drivers/video/mmp/core.c @@ -173,7 +173,7 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info) + sizeof(struct mmp_overlay) * info->overlay_num; path = kzalloc(size, GFP_KERNEL); if (!path) - goto failed; + return NULL; /* path set */ mutex_init(&path->access_ok); @@ -219,11 +219,6 @@ struct mmp_path *mmp_register_path(struct mmp_path_info *info) mutex_unlock(&disp_lock); return path; - -failed: - kfree(path); - mutex_unlock(&disp_lock); - return NULL; } EXPORT_SYMBOL_GPL(mmp_register_path);