From: Jarkko Nikula Date: Thu, 19 Jun 2014 06:32:05 +0000 (+0300) Subject: ASoC: max98090: Fix missing free_irq X-Git-Tag: v3.17-rc1~101^2~5^2~20^2~1^4 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4adeb0ccf86a5af1825bbfe290dee9e60a5ab870;p=karo-tx-linux.git ASoC: max98090: Fix missing free_irq max98090.c doesn't free the threaded interrupt it requests. This causes an oops when doing "cat /proc/interrupts" after snd-soc-max98090.ko is unloaded. Fix this by requesting the interrupt by using devm_request_threaded_irq(). Signed-off-by: Jarkko Nikula Cc: Stable # 3.10+ Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index f5fccc7a8e89..d97f1ce7ff7d 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -2284,7 +2284,7 @@ static int max98090_probe(struct snd_soc_codec *codec) /* Register for interrupts */ dev_dbg(codec->dev, "irq = %d\n", max98090->irq); - ret = request_threaded_irq(max98090->irq, NULL, + ret = devm_request_threaded_irq(codec->dev, max98090->irq, NULL, max98090_interrupt, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "max98090_interrupt", codec); if (ret < 0) {