From: Laurent Pinchart Date: Sat, 15 Feb 2014 00:40:48 +0000 (-0300) Subject: [media] omap3isp: Don't try to locate external subdev for mem-to-mem pipelines X-Git-Tag: v3.15-rc1~85^2~356 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4b2f1ed15e01984b5225df715df949084796dfb9;p=karo-tx-linux.git [media] omap3isp: Don't try to locate external subdev for mem-to-mem pipelines Memory-to-memory pipelines have no external subdev, we shouldn't try to locate one and validate its configuration. The driver currently works by chance due to another bug that results in failure to locate the external subdev being ignored. This gets rid of the "omap3isp omap3isp: can't find source, failing now" error message in the kernel log when operating on a memory-to-memory pipeline. Signed-off-by: Laurent Pinchart Acked-by: Sakari Ailus Tested-by: Peter Meerwald Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index 856fdf554035..313fd13994a1 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -888,6 +888,10 @@ static int isp_video_check_external_subdevs(struct isp_video *video, unsigned int i; int ret = 0; + /* Memory-to-memory pipelines have no external subdev. */ + if (pipe->input != NULL) + return 0; + for (i = 0; i < ARRAY_SIZE(ents); i++) { /* Is the entity part of the pipeline? */ if (!(pipe->entities & (1 << ents[i]->id)))