From: Markus Elfring Date: Wed, 4 Feb 2015 20:32:27 +0000 (+0100) Subject: drivers/macintosh: Delete an unnecessary check before the function call "of_node_put" X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4b7d8358819da84b1272cdae29ace4680254a104;p=linux-beck.git drivers/macintosh: Delete an unnecessary check before the function call "of_node_put" The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Benjamin Herrenschmidt --- diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c index 10ae69bcbbd2..d531f804455d 100644 --- a/drivers/macintosh/smu.c +++ b/drivers/macintosh/smu.c @@ -557,8 +557,7 @@ int __init smu_init (void) return 0; fail_msg_node: - if (smu->msg_node) - of_node_put(smu->msg_node); + of_node_put(smu->msg_node); fail_db_node: of_node_put(smu->db_node); fail_bootmem: