From: Michael Zaidman Date: Mon, 15 Feb 2010 08:02:32 +0000 (+0200) Subject: Bug: do_reset issued via netconsole does not reset mpc83xx cpu. X-Git-Tag: v2010.03-rc1~57^2~3 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4c006dd1501283eecaea813a0e5e225e9ee6fdeb;p=karo-tx-uboot.git Bug: do_reset issued via netconsole does not reset mpc83xx cpu. The do_reset routine in the cpu/mpc83xx/cpu.c file does not reset the mpc83xx cpu when issued via netconsole. Moving the console output "resetting the board." to the beginning of the routine before disabling interrupts solved the problem. Signed-off-by: Michael Zaidman Acked-by: Detlev Zundel Signed-off-by: Kim Phillips --- diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c index e38a3722ca..51180d6daa 100644 --- a/cpu/mpc83xx/cpu.c +++ b/cpu/mpc83xx/cpu.c @@ -199,7 +199,10 @@ do_reset (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) volatile immap_t *immap = (immap_t *) CONFIG_SYS_IMMR; + puts("Resetting the board.\n"); + #ifdef MPC83xx_RESET + /* Interrupts and MMU off */ __asm__ __volatile__ ("mfmsr %0":"=r" (msr):); @@ -214,9 +217,6 @@ do_reset (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) /* confirm Reset Control Reg is enabled */ while(!((immap->reset.rcer) & RCER_CRE)); - printf("Resetting the board."); - printf("\n"); - udelay(200); /* perform reset, only one bit */ @@ -238,8 +238,6 @@ do_reset (cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) */ addr = CONFIG_SYS_RESET_ADDRESS; - printf("resetting the board."); - printf("\n"); ((void (*)(void)) addr) (); #endif /* MPC83xx_RESET */