From: Jes Sorensen Date: Mon, 29 Feb 2016 22:04:07 +0000 (-0500) Subject: rtl8xxxu: Fix incorrect test for auto LLT failure X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4de24819192eb507525fa24182c86c2073accd12;p=linux-beck.git rtl8xxxu: Fix incorrect test for auto LLT failure The logic for testing auto load failure in rtl8xxxu_auto_llt_table() was inverted. Signed-off-by: Jes Sorensen Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c index ad5b15cb07b6..68d6bb89f719 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c @@ -2781,7 +2781,6 @@ static int rtl8xxxu_auto_llt_table(struct rtl8xxxu_priv *priv, u8 last_tx_page) int i; val32 = rtl8xxxu_read32(priv, REG_AUTO_LLT); - pr_info("AUTO_LLT = %08x\n", val32); val32 |= AUTO_LLT_INIT_LLT; rtl8xxxu_write32(priv, REG_AUTO_LLT, val32); @@ -2792,12 +2791,10 @@ static int rtl8xxxu_auto_llt_table(struct rtl8xxxu_priv *priv, u8 last_tx_page) usleep_range(2, 4); } - if (i) { + if (!i) { ret = -EBUSY; dev_warn(&priv->udev->dev, "LLT table init failed\n"); } - else - dev_warn(&priv->udev->dev, "LLT table init success\n"); return ret; }