From: Johan Hovold <johan@kernel.org>
Date: Tue, 8 Nov 2016 12:31:18 +0000 (+0100)
Subject: staging: greybus: uart: fix invalid user-pointer check
X-Git-Tag: v4.10-rc1~148^2~290
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4dfc109c7118ed8e2806c5395b9e9dd8f851f992;p=karo-tx-linux.git

staging: greybus: uart: fix invalid user-pointer check

Drop invalid user-pointer check from TIOCGSERIAL handler.

A NULL-pointer can be valid in user space and copy_to_user() takes care
of sanity checking.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index c1f6abb57dc3..35755f70d5a2 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -623,9 +623,6 @@ static int get_serial_info(struct gb_tty *gb_tty,
 {
 	struct serial_struct tmp;
 
-	if (!info)
-		return -EINVAL;
-
 	memset(&tmp, 0, sizeof(tmp));
 	tmp.flags = ASYNC_LOW_LATENCY | ASYNC_SKIP_TEST;
 	tmp.type = PORT_16550A;