From: Mikulas Patocka Date: Wed, 24 Oct 2012 23:11:18 +0000 (+1100) Subject: mempool_alloc can't fail if __GFP_WAIT is specified, so the condition X-Git-Tag: next-20121025~48^2~2 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=4e2029ae3580afe49e9cc378ff63e93617a4ca41;p=karo-tx-linux.git mempool_alloc can't fail if __GFP_WAIT is specified, so the condition that tests if read_record is non-NULL is always true. Signed-off-by: Mikulas Patocka Signed-off-by: Alasdair G Kergon --- diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c index fd61f98ee1f6..b37467618b16 100644 --- a/drivers/md/dm-raid1.c +++ b/drivers/md/dm-raid1.c @@ -1195,11 +1195,9 @@ static int mirror_map(struct dm_target *ti, struct bio *bio, return -EIO; read_record = mempool_alloc(ms->read_record_pool, GFP_NOIO); - if (likely(read_record)) { - dm_bio_record(&read_record->details, bio); - map_context->ptr = read_record; - read_record->m = m; - } + dm_bio_record(&read_record->details, bio); + map_context->ptr = read_record; + read_record->m = m; map_bio(m, bio);