From: Andrew Morton Date: Wed, 30 Nov 2011 04:11:47 +0000 (+1100) Subject: rtc-ab8500-add-calibration-attribute-to-ab8500-rtc-checkpatch-fixes X-Git-Tag: next-20111130~3^2~63 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5025d989c8712c2b02338526cade105baef035b4;p=karo-tx-linux.git rtc-ab8500-add-calibration-attribute-to-ab8500-rtc-checkpatch-fixes Cc: Alessandro Zummo WARNING: line over 80 characters #48: FILE: drivers/rtc/rtc-ab8500.c:268: + * Check that the calibration value (which is in units of 0.5 parts-per-million) ERROR: need consistent spacing around '-' (ctx:WxV) #64: FILE: drivers/rtc/rtc-ab8500.c:284: + rtccal = ~(calibration -1) | 0x80; ^ total: 1 errors, 1 warnings, 139 lines checked ./patches/rtc-ab8500-add-calibration-attribute-to-ab8500-rtc.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Alessandro Zummo Cc: Linus Walleij Cc: Mark Godfrey Signed-off-by: Andrew Morton --- diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c index ad90a5b4298c..ec67ee6f8830 100644 --- a/drivers/rtc/rtc-ab8500.c +++ b/drivers/rtc/rtc-ab8500.c @@ -281,7 +281,7 @@ static int ab8500_rtc_set_calibration(struct device *dev, int calibration) if (calibration >= 0) rtccal = 0x7F & calibration; else - rtccal = ~(calibration -1) | 0x80; + rtccal = ~(calibration - 1) | 0x80; retval = abx500_set_register_interruptible(dev, AB8500_RTC, AB8500_RTC_CALIB_REG, rtccal);