From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 3 Feb 2015 14:27:38 +0000 (-0300)
Subject: [media] V4L2: Delete an unnecessary check before the function call "media_entity_put"
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5164d6aac0ed1b711a7b29bb556844e40f422ec6;p=linux-beck.git

[media] V4L2: Delete an unnecessary check before the function call "media_entity_put"

The media_entity_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
---

diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c
index 8bafb942552b..63596063b213 100644
--- a/drivers/media/v4l2-core/v4l2-subdev.c
+++ b/drivers/media/v4l2-core/v4l2-subdev.c
@@ -93,8 +93,7 @@ static int subdev_open(struct file *file)
 
 err:
 #if defined(CONFIG_MEDIA_CONTROLLER)
-	if (entity)
-		media_entity_put(entity);
+	media_entity_put(entity);
 #endif
 	v4l2_fh_del(&subdev_fh->vfh);
 	v4l2_fh_exit(&subdev_fh->vfh);