From: Jim Cromie Date: Tue, 1 May 2012 11:23:12 +0000 (-0600) Subject: dynamic_debug: use printk(KERN_WARNING..) in stub function X-Git-Tag: next-20120503~18^2~10 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=516cf1be07cf3ab52e6d2f64da33b0fa5d9e0042;p=karo-tx-linux.git dynamic_debug: use printk(KERN_WARNING..) in stub function drivers/infiniband/ulp/srp/ib_srp.c #defines pr_fmt() PFX fmt, but PFX is not #defined until after headers are included. This results in a bad expansion of the pr_warn() in the stub function. 2084c2084 < printk("<4>" PFX "dyndbg supported only in " "CONFIG_DYNAMIC_DEBUG builds\n") Signed-off-by: Greg Kroah-Hartman --- diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 4697e4b59d6f..c18257b0fa72 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -109,7 +109,8 @@ static inline int ddebug_dyndbg_module_param_cb(char *param, char *val, const char *modname) { if (strstr(param, "dyndbg")) { - pr_warn("dyndbg supported only in " + /* avoid pr_warn(), which wants pr_fmt() fully defined */ + printk(KERN_WARNING "dyndbg param is supported only in " "CONFIG_DYNAMIC_DEBUG builds\n"); return 0; /* allow and ignore */ }