From: Axel Lin <axel.lin@ingics.com>
Date: Fri, 20 Sep 2013 10:39:18 +0000 (+0800)
Subject: spi: efm32: Don't call kfree() after spi_master_put()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=57841439b62e3ddb5ee50e765aa50330dde612d0;p=linux-beck.git

spi: efm32: Don't call kfree() after spi_master_put()

Calling kfree() to clean up the memory obtained from spi_alloc_master() is
wrong as this is done in spi_master_release() when spi_master->dev's refcount
reaches zero.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
---

diff --git a/drivers/spi/spi-efm32.c b/drivers/spi/spi-efm32.c
index 7d84418a01d8..5b3117f69507 100644
--- a/drivers/spi/spi-efm32.c
+++ b/drivers/spi/spi-efm32.c
@@ -467,7 +467,6 @@ err_disable_clk:
 		clk_disable_unprepare(ddata->clk);
 err:
 		spi_master_put(master);
-		kfree(master);
 	}
 
 	return ret;
@@ -484,7 +483,6 @@ static int efm32_spi_remove(struct platform_device *pdev)
 	free_irq(ddata->rxirq, ddata);
 	clk_disable_unprepare(ddata->clk);
 	spi_master_put(master);
-	kfree(master);
 
 	return 0;
 }