From: Thierry Reding <thierry.reding@gmail.com>
Date: Mon, 20 Jul 2015 07:56:05 +0000 (+0200)
Subject: pwm: sysfs: Properly convert from enum to string
X-Git-Tag: v4.3-rc1~31^2~11
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5a063d87e97df28ca0b00807bc4d6fa11c5a5107;p=karo-tx-linux.git

pwm: sysfs: Properly convert from enum to string

The current code will check for polarity in a boolean way. While it is
correct that polarity is either normal or inversed, make it more obvious
that it's an enumeration by using a switch statement and explicit
matches on the enumeration values.

Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
---

diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
index ac0abecfbaa0..fbfc9e903230 100644
--- a/drivers/pwm/sysfs.c
+++ b/drivers/pwm/sysfs.c
@@ -133,9 +133,19 @@ static ssize_t pwm_polarity_show(struct device *child,
 				 char *buf)
 {
 	const struct pwm_device *pwm = child_to_pwm_device(child);
+	const char *polarity = "unknown";
 
-	return sprintf(buf, "%s\n",
-		       pwm_get_polarity(pwm) ? "inversed" : "normal");
+	switch (pwm_get_polarity(pwm)) {
+	case PWM_POLARITY_NORMAL:
+		polarity = "normal";
+		break;
+
+	case PWM_POLARITY_INVERSED:
+		polarity = "inversed";
+		break;
+	}
+
+	return sprintf(buf, "%s\n", polarity);
 }
 
 static ssize_t pwm_polarity_store(struct device *child,