From: Mark Brown <broonie@opensource.wolfsonmicro.com>
Date: Tue, 8 Jan 2013 13:44:50 +0000 (+0000)
Subject: regmap: debugfs: Ensure a correct return value for empty caches
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5bd9f4bb34c16b62725b9486a290c01b1fdfec1c;p=linux-beck.git

regmap: debugfs: Ensure a correct return value for empty caches

This should never happen in the real world.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---

diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 9099cd33fbcb..720e14248167 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -116,6 +116,16 @@ static unsigned int regmap_debugfs_get_dump_start(struct regmap *map,
 		}
 	}
 
+	/*
+	 * This should never happen; we return above if we fail to
+	 * allocate and we should never be in this code if there are
+	 * no registers at all.
+	 */
+	if (list_empty(&map->debugfs_off_cache)) {
+		WARN_ON(list_empty(&map->debugfs_off_cache));
+		return base;
+	}
+
 	/* Find the relevant block */
 	list_for_each_entry(c, &map->debugfs_off_cache, list) {
 		if (from >= c->min && from <= c->max) {