From: Greg Kroah-Hartman <gregkh@suse.de>
Date: Thu, 13 Sep 2007 09:53:13 +0000 (-0700)
Subject: sysfs: spit a warning to users when they try to create a duplicate sysfs file
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5c3e8964ce87477a12e3e9edc3742156a3929a74;p=linux-beck.git

sysfs: spit a warning to users when they try to create a duplicate sysfs file

We want to let people know when we create a duplicate sysfs file, as
they need to fix up their code.


Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index da4bb66a610c..5d95aa8e23c6 100644
--- a/fs/sysfs/dir.c
+++ b/fs/sysfs/dir.c
@@ -428,8 +428,12 @@ void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt,
  */
 int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
 {
-	if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
+	if (sysfs_find_dirent(acxt->parent_sd, sd->s_name)) {
+		printk(KERN_WARNING "sysfs: duplicate filename '%s' "
+		       "can not be created\n", sd->s_name);
+		WARN_ON(1);
 		return -EEXIST;
+	}
 
 	sd->s_parent = sysfs_get(acxt->parent_sd);