From: Jani Nikula <ext-jani.1.nikula@nokia.com>
Date: Tue, 1 Jun 2010 15:08:18 +0000 (+0300)
Subject: OMAP: DSS2: OMAPFB: Fix sysfs mirror input check
X-Git-Tag: v2.6.36-rc1~487^2~9
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5cb33e2166067e1fff7ebc3b849ec70a6fd7ec1d;p=karo-tx-linux.git

OMAP: DSS2: OMAPFB: Fix sysfs mirror input check

Using bool silently converted input to 0 or 1, making the range check
useless. Use unsigned long instead, and convert to bool later. Found by
Coverity.

Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
---

diff --git a/drivers/video/omap2/omapfb/omapfb-sysfs.c b/drivers/video/omap2/omapfb/omapfb-sysfs.c
index 51c13c366bf3..6f9c72cd6bb0 100644
--- a/drivers/video/omap2/omapfb/omapfb-sysfs.c
+++ b/drivers/video/omap2/omapfb/omapfb-sysfs.c
@@ -102,7 +102,7 @@ static ssize_t store_mirror(struct device *dev,
 {
 	struct fb_info *fbi = dev_get_drvdata(dev);
 	struct omapfb_info *ofbi = FB2OFB(fbi);
-	bool mirror;
+	unsigned long mirror;
 	int r;
 	struct fb_var_screeninfo new_var;