From: Ed Cashin <ecashin@coraid.com>
Date: Thu, 29 Nov 2012 03:19:04 +0000 (+1100)
Subject: aoe: avoid using skb member after dev_queue_xmit
X-Git-Tag: next-20121205~1^2~58
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5d2db6e6f6e5b8a749e2ac16ad509770b55d99d4;p=karo-tx-linux.git

aoe: avoid using skb member after dev_queue_xmit

After calling dev_queue_xmit it is no longer safe to access the
members of the skb.

Signed-off-by: Ed Cashin <ecashin@coraid.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe/aoenet.c
index 3cf068b74b77..24eca2bf9416 100644
--- a/drivers/block/aoe/aoenet.c
+++ b/drivers/block/aoe/aoenet.c
@@ -55,12 +55,14 @@ static int
 tx(void) __must_hold(&txlock)
 {
 	struct sk_buff *skb;
+	struct net_device *ifp;
 
 	while ((skb = skb_dequeue(&skbtxq))) {
 		spin_unlock_irq(&txlock);
+		ifp = skb->dev;
 		if (dev_queue_xmit(skb) == NET_XMIT_DROP && net_ratelimit())
 			pr_warn("aoe: packet could not be sent on %s.  %s\n",
-				skb->dev ? skb->dev->name : "netif",
+				ifp ? ifp->name : "netif",
 				"consider increasing tx_queue_len");
 		spin_lock_irq(&txlock);
 	}