From: David Henningsson Date: Fri, 4 Jan 2013 16:02:18 +0000 (+0100) Subject: ALSA: usb - fix race in creation of M-Audio Fast track pro driver X-Git-Tag: v3.7.4~21 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5dfa9f89ba0acbb6074c545c53a67a5af33990e0;p=karo-tx-linux.git ALSA: usb - fix race in creation of M-Audio Fast track pro driver commit b98ae2729dea161edc96c9d177459b6c28bcbba5 upstream. A patch in the 3.2 kernel caused regression with hotplugging the M-Audio Fast track pro, or sound after suspend. I don't have the device so I haven't done a full analysis, but it seems userspace (both udev and pulseaudio) got confused when a card was created, immediately destroyed, and then created again. However, at least one person in the bug report (martin djfun) reports that this patch resolves the issue for him. It also leaves a message in the log: "snd-usb-audio: probe of 1-1.1:1.1 failed with error -5" which is a bit misleading. It is better than non-working audio, but maybe there's a more elegant solution? BugLink: https://bugs.launchpad.net/bugs/1095315 Signed-off-by: David Henningsson Signed-off-by: Takashi Iwai Cc: CAI Qian Signed-off-by: Greg Kroah-Hartman --- diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c index 0f58b4b6d702..b8d1ad13f8c0 100644 --- a/sound/usb/quirks.c +++ b/sound/usb/quirks.c @@ -387,11 +387,13 @@ static int snd_usb_fasttrackpro_boot_quirk(struct usb_device *dev) * rules */ err = usb_driver_set_configuration(dev, 2); - if (err < 0) { + if (err < 0) snd_printdd("error usb_driver_set_configuration: %d\n", err); - return -ENODEV; - } + /* Always return an error, so that we stop creating a device + that will just be destroyed and recreated with a new + configuration */ + return -ENODEV; } else snd_printk(KERN_INFO "usb-audio: Fast Track Pro config OK\n");