From: Sachin Kamat Date: Tue, 20 Nov 2012 09:59:01 +0000 (-0800) Subject: leds: lp5523: Fix return value X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5ebab74a711388fc30e6d839eee79aa06d1ce0af;p=linux-beck.git leds: lp5523: Fix return value Return the value obtained from i2c_smbus_read_byte_data() instead of -EIO. Silences the following smatch warning: drivers/leds/leds-lp5523.c:174 lp5523_read() info: why not propagate 'ret' from i2c_smbus_read_byte_data() instead of -5? Signed-off-by: Sachin Kamat Signed-off-by: Bryan Wu --- diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 59ec383900de..eb89cbd419ca 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -171,7 +171,7 @@ static int lp5523_read(struct i2c_client *client, u8 reg, u8 *buf) s32 ret = i2c_smbus_read_byte_data(client, reg); if (ret < 0) - return -EIO; + return ret; *buf = ret; return 0;