From: Ezequiel Garcia Date: Thu, 14 Nov 2013 21:25:32 +0000 (-0300) Subject: mtd: nand: pxa3xx: Remove READ0 switch/case falltrough X-Git-Tag: next-20131128~37^2~20 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=5ff32d5b994752d1187c1e6a4486a01e8b9c32e2;p=karo-tx-linux.git mtd: nand: pxa3xx: Remove READ0 switch/case falltrough READ0 and READOOB command preparation has a falltrough to SEQIN case, where the command address is specified. This is certainly confusing and makes the code less readable with no added value. Let's remove it. Signed-off-by: Ezequiel Garcia Tested-by: Daniel Mack Signed-off-by: Brian Norris --- diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c index 5e0d201ca907..eea1ff84476a 100644 --- a/drivers/mtd/nand/pxa3xx_nand.c +++ b/drivers/mtd/nand/pxa3xx_nand.c @@ -669,6 +669,11 @@ static int prepare_command_pool(struct pxa3xx_nand_info *info, int command, if (mtd->writesize >= PAGE_CHUNK_SIZE) info->ndcb0 |= NDCB0_DBC | (NAND_CMD_READSTART << 8); + set_command_address(info, mtd->writesize, column, page_addr); + info->buf_count = mtd->writesize + mtd->oobsize; + memset(info->data_buff, 0xFF, info->buf_count); + break; + case NAND_CMD_SEQIN: set_command_address(info, mtd->writesize, column, page_addr);