From: Cheah Kok Cheong Date: Tue, 21 Feb 2017 17:25:08 +0000 (+0800) Subject: Staging: comedi: drivers: comedi_test: Avoid multiple line dereference X-Git-Tag: v4.12-rc1~84^2~979 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=607b6cd3d083ae1deaf93ff2634abe147459c9bc;p=karo-tx-linux.git Staging: comedi: drivers: comedi_test: Avoid multiple line dereference Fix checkpatch warning "Avoid multiple line dereference" using a pointer variable to avoid line wrap. Signed-off-by: Cheah Kok Cheong Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/comedi_test.c b/drivers/staging/comedi/drivers/comedi_test.c index 2a063f07fe7b..ccfd642998be 100644 --- a/drivers/staging/comedi/drivers/comedi_test.c +++ b/drivers/staging/comedi/drivers/comedi_test.c @@ -480,11 +480,11 @@ static void waveform_ao_timer(unsigned long arg) /* output the last scan */ for (i = 0; i < cmd->scan_end_arg; i++) { unsigned int chan = CR_CHAN(cmd->chanlist[i]); + unsigned short *pd; - if (comedi_buf_read_samples(s, - &devpriv-> - ao_loopbacks[chan], - 1) == 0) { + pd = &devpriv->ao_loopbacks[chan]; + + if (!comedi_buf_read_samples(s, pd, 1)) { /* unexpected underrun! (cancelled?) */ async->events |= COMEDI_CB_OVERFLOW; goto underrun;