From: Alexandre Bailon <abailon@baylibre.com>
Date: Mon, 15 Jun 2015 16:08:11 +0000 (+0200)
Subject: greybus: es2.c: Don't use magic value for USB control request
X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~1462
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=611c17390e7b47b3f311a9304439eaa4de94dbae;p=karo-tx-linux.git

greybus: es2.c: Don't use magic value for USB control request

Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index 5257779f7aed..a35c79a32420 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -46,6 +46,12 @@ static DEFINE_KFIFO(apb1_log_fifo, char, APB1_LOG_SIZE);
  */
 #define NUM_CPORT_OUT_URB	8
 
+/* vendor request AP message */
+#define REQUEST_SVC		0x01
+
+/* vendor request APB1 log */
+#define REQUEST_LOG		0x02
+
 /**
  * es1_ap_dev - ES1 USB Bridge to AP structure
  * @usb_dev: pointer to the USB device we are.
@@ -103,7 +109,7 @@ static int submit_svc(struct svc_msg *svc_msg, struct greybus_host_device *hd)
 	retval = usb_control_msg(es1->usb_dev,
 				 usb_sndctrlpipe(es1->usb_dev,
 						 es1->control_endpoint),
-				 0x01,	/* vendor request AP message */
+				 REQUEST_SVC,
 				 USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
 				 0x00, 0x00,
 				 (char *)svc_msg,
@@ -410,7 +416,7 @@ static void apb1_log_get(struct es1_ap_dev *es1, char *buf)
 		retval = usb_control_msg(es1->usb_dev,
 					usb_rcvctrlpipe(es1->usb_dev,
 							es1->control_endpoint),
-					0x02,	/* vendor request APB1 log */
+					REQUEST_LOG,
 					USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_INTERFACE,
 					0x00, 0x00,
 					buf,