From: Guenter Roeck Date: Thu, 21 Jun 2012 13:26:12 +0000 (-0700) Subject: hwmon: (fam15h_power) Fix unintentional integer overflow X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=62867d491a27affee36194d4856564f2f4e12b3c;p=linux-beck.git hwmon: (fam15h_power) Fix unintentional integer overflow Expression with two unsigned integer variables is calculated as unsigned integer before it is converted to u64. This may result in an integer overflow. Fix by typecasting the left operand to u64 before performing the left shift. This patch addresses Coverity #402320: Unintentional integer overflow. Signed-off-by: Guenter Roeck Acked-by: Jean Delvare Acked-by: Andreas Herrmann --- diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c index 6b13f1a4dc27..2764b78a784b 100644 --- a/drivers/hwmon/fam15h_power.c +++ b/drivers/hwmon/fam15h_power.c @@ -67,7 +67,8 @@ static ssize_t show_power(struct device *dev, REG_TDP_LIMIT3, &val); tdp_limit = val >> 16; - curr_pwr_watts = (tdp_limit + data->base_tdp) << running_avg_range; + curr_pwr_watts = ((u64)(tdp_limit + + data->base_tdp)) << running_avg_range; curr_pwr_watts -= running_avg_capture; curr_pwr_watts *= data->tdp_to_watts;