From: Christian Riesch Date: Tue, 31 Mar 2015 21:29:22 +0000 (+0200) Subject: mtd: cfi_cmdset_0002: Initialize datum before calling map_word_load_partial X-Git-Tag: v4.2-rc1~139^2~10 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=636fdbf88efe069f9951d1b7df8d3fd82060dc60;p=karo-tx-linux.git mtd: cfi_cmdset_0002: Initialize datum before calling map_word_load_partial In do_otp_write we must initialize the variable datum before calling map_word_load_partial. Otherwise the upper bits of datum may be undefined, which later causes problems in chip_good called by do_write_oneword. Signed-off-by: Christian Riesch Signed-off-by: Brian Norris --- diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index c50d8cf0f60d..c3624eb571d1 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -1295,7 +1295,7 @@ static int do_otp_write(struct map_info *map, struct flchip *chip, loff_t adr, unsigned long bus_ofs = adr & ~(map_bankwidth(map)-1); int gap = adr - bus_ofs; int n = min_t(int, len, map_bankwidth(map) - gap); - map_word datum; + map_word datum = map_word_ff(map); if (n != map_bankwidth(map)) { /* partial write of a word, load old contents */