From: Wei Yongjun Date: Fri, 21 Sep 2012 06:30:50 +0000 (+0800) Subject: ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=64de3a00a16bcdf940cbebb1b2dc05d7cc13fef5;p=linux-beck.git ARM: OMAP: hsmmc: fix return value check in omap_hsmmc_init_one() In case of error, the function omap_device_alloc() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Signed-off-by: Tony Lindgren --- diff --git a/arch/arm/mach-omap2/hsmmc.c b/arch/arm/mach-omap2/hsmmc.c index 03ebf47cfa9a..4d3a6324155f 100644 --- a/arch/arm/mach-omap2/hsmmc.c +++ b/arch/arm/mach-omap2/hsmmc.c @@ -523,7 +523,7 @@ static void __init omap_hsmmc_init_one(struct omap2_hsmmc_info *hsmmcinfo, dev_set_name(&pdev->dev, "%s.%d", pdev->name, pdev->id); od = omap_device_alloc(pdev, ohs, 1, NULL, 0); - if (!od) { + if (IS_ERR(od)) { pr_err("Could not allocate od for %s\n", name); goto put_pdev; }