From: Ian Abbott Date: Mon, 14 Nov 2016 20:16:21 +0000 (+0000) Subject: staging: comedi: ni_mio_common: fix M Series ni_ai_insn_read() data mask X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=655c4d442d1213b617926cc6d54e2a9a793fb46b;p=linux-beck.git staging: comedi: ni_mio_common: fix M Series ni_ai_insn_read() data mask For NI M Series cards, the Comedi `insn_read` handler for the AI subdevice is broken due to ANDing the value read from the AI FIFO data register with an incorrect mask. The incorrect mask clears all but the most significant bit of the sample data. It should preserve all the sample data bits. Correct it. Fixes: 817144ae7fda ("staging: comedi: ni_mio_common: remove unnecessary use of 'board->adbits'") Signed-off-by: Ian Abbott Cc: Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c index 9812508fe8d3..95435395c746 100644 --- a/drivers/staging/comedi/drivers/ni_mio_common.c +++ b/drivers/staging/comedi/drivers/ni_mio_common.c @@ -1832,7 +1832,7 @@ static int ni_ai_insn_read(struct comedi_device *dev, unsigned int *data) { struct ni_private *devpriv = dev->private; - unsigned int mask = (s->maxdata + 1) >> 1; + unsigned int mask = s->maxdata; int i, n; unsigned int signbits; unsigned int d;