From: Brian Masney Date: Tue, 17 Jan 2017 09:24:56 +0000 (-0500) Subject: staging: iio: isl29028: remove unnecessary error logging in isl29028_chip_init_and_po... X-Git-Tag: v4.11-rc1~116^2~272^2~12 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=65ac716b2013b97d68dbec4be0b5fb01a16efe7e;p=karo-tx-linux.git staging: iio: isl29028: remove unnecessary error logging in isl29028_chip_init_and_power_on() If the call to isl29028_chip_init_and_power_on() in isl29028_probe() fails, then isl29028_probe() will log an error message. All of the error paths in that call path already have error logging in place. This patch removes the unnecessary logging. Signed-off-by: Brian Masney Signed-off-by: Jonathan Cameron --- diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c index cffecf9d6bde..be1fc4a8960e 100644 --- a/drivers/staging/iio/light/isl29028.c +++ b/drivers/staging/iio/light/isl29028.c @@ -528,10 +528,8 @@ static int isl29028_probe(struct i2c_client *client, } ret = isl29028_chip_init_and_power_on(chip); - if (ret < 0) { - dev_err(&client->dev, "chip initialization failed: %d\n", ret); + if (ret < 0) return ret; - } indio_dev->info = &isl29028_info; indio_dev->channels = isl29028_channels;