From: Pavel Emelyanov Date: Mon, 1 Oct 2007 21:41:13 +0000 (-0700) Subject: 9PFS: clean up explicit check for mandatory locks X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=66abe5f257e719547744fdb8691cf5d20603f051;p=mv-sheeva.git 9PFS: clean up explicit check for mandatory locks The __mandatory_lock(inode) macro makes the same check, but makes the code more readable. Signed-off-by: Pavel Emelyanov Cc: Eric Van Hensbergen Cc: Ron Minnich Cc: Latchesar Ionkov Signed-off-by: Andrew Morton --- diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index 2a40c2946d0..716691689fd 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c @@ -105,7 +105,7 @@ static int v9fs_file_lock(struct file *filp, int cmd, struct file_lock *fl) P9_DPRINTK(P9_DEBUG_VFS, "filp: %p lock: %p\n", filp, fl); /* No mandatory locks */ - if ((inode->i_mode & (S_ISGID | S_IXGRP)) == S_ISGID) + if (__mandatory_lock(inode)) return -ENOLCK; if ((IS_SETLK(cmd) || IS_SETLKW(cmd)) && fl->fl_type != F_UNLCK) {