From: FUJITA Tomonori Date: Mon, 25 Feb 2008 13:23:45 +0000 (+0100) Subject: [SCSI] ps3rom: fix wrong resid calculation bug X-Git-Tag: v2.6.25-rc5~25^2~16 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=67768f675ffa587d6081ed1d259e796823023926;p=karo-tx-linux.git [SCSI] ps3rom: fix wrong resid calculation bug sg driver rounds up the length in struct scatterlist to be a multiple of 512 in some conditions. So LLDs can't use the data length in a sg list to calculate residual. Instead, the length in struct scsi_cmnd should be used. [Geert: the variable buflen already contains scsi_bufflen(cmd)] Signed-off-by: FUJITA Tomonori Signed-off-by: Geert Uytterhoeven Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c index 0cd614a0fa73..e052c8479d51 100644 --- a/drivers/scsi/ps3rom.c +++ b/drivers/scsi/ps3rom.c @@ -124,7 +124,7 @@ static int fill_from_dev_buffer(struct scsi_cmnd *cmd, const void *buf) } req_len += sgpnt->length; } - scsi_set_resid(cmd, req_len - act_len); + scsi_set_resid(cmd, buflen - act_len); return 0; }