From: Al Viro Date: Mon, 9 Mar 2015 03:36:51 +0000 (-0400) Subject: drop bogus check in file_open_root() X-Git-Tag: KARO-TXA5-2015-06-26~105^2~54 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=6bf375f6a770456b87e6008c86f1901b5161409f;p=karo-tx-linux.git drop bogus check in file_open_root() For one thing, LOOKUP_DIRECTORY will be dealt with in do_last(). For another, name can be an empty string, but not NULL - no callers pass that and it would oops immediately if they would. Signed-off-by: Al Viro --- diff --git a/fs/open.c b/fs/open.c index 33f9cbf2610b..ebcc7df0c9b6 100644 --- a/fs/open.c +++ b/fs/open.c @@ -988,9 +988,6 @@ struct file *file_open_root(struct dentry *dentry, struct vfsmount *mnt, return ERR_PTR(err); if (flags & O_CREAT) return ERR_PTR(-EINVAL); - if (!filename && (flags & O_DIRECTORY)) - if (!dentry->d_inode->i_op->lookup) - return ERR_PTR(-ENOTDIR); return do_file_open_root(dentry, mnt, filename, &op); } EXPORT_SYMBOL(file_open_root);