From: Kees Cook <keescook@chromium.org>
Date: Wed, 11 Sep 2013 04:41:34 +0000 (-0700)
Subject: bcache: defensively handle format strings
X-Git-Tag: next-20130912~34^2~6^2
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=6c26e50cea3a04fd50cb9d55504b081d2e3c5fe7;p=karo-tx-linux.git

bcache: defensively handle format strings

Just to be safe, call the error reporting function with "%s" to avoid
any possible future format string leak.

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kent Overstreet <kmo@daterainc.com>
---

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 70708ab0b8f9..dec15cd2d797 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1670,7 +1670,7 @@ static void run_cache_set(struct cache_set *c)
 err:
 	closure_sync(&cl);
 	/* XXX: test this, it's broken */
-	bch_cache_set_error(c, err);
+	bch_cache_set_error(c, "%s", err);
 }
 
 static bool can_attach_cache(struct cache *ca, struct cache_set *c)